Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBQ Contributor Airdrop #90

Closed
0x4007 opened this issue Sep 25, 2023 · 68 comments · Fixed by EtherealGlow/ContributionAnalyzer#2
Closed

UBQ Contributor Airdrop #90

0x4007 opened this issue Sep 25, 2023 · 68 comments · Fixed by EtherealGlow/ContributionAnalyzer#2

Comments

@0x4007
Copy link
Member

0x4007 commented Sep 25, 2023

Make a command line tool that will tally up everybody's contributions from the last year.

We can parse all the permits generated across all of our repos and then drop 1 UBQ per dollar earned.

We should run this script when we enable UBQ token payouts

@b4s36t4
Copy link

b4s36t4 commented Nov 29, 2023

@pavlovcik Would love to work on this. Can you explain more on this?

Copy link

ubiquibot bot commented Nov 29, 2023

Available commands

- /start: Assign the origin sender to the issue automatically.
- /stop: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /autopay: Toggle automatic payment for the completion of the current issue.
- /query: Comments the users multiplier and address
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0x0000000000000000000000000000000000000000
  ex2: /wallet vitalik.eth

@b4s36t4

@0x4007
Copy link
Member Author

0x4007 commented Nov 29, 2023

  • Use @ubiquity/ts-template
  • go through every "closed as completed" issue across every ubiquity repository and tally up the payments for every contributor
  • output results in a csv

@b4s36t4
Copy link

b4s36t4 commented Nov 29, 2023

Cool, Will do that.

@b4s36t4
Copy link

b4s36t4 commented Nov 29, 2023

/start

Copy link

ubiquibot bot commented Nov 29, 2023

Deadline Wed, 06 Dec 2023 07:05:13 UTC
Registered Wallet 0xCee33C98410DEbe67A319Cb94F39e403435Df319
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @EtherealGlow
    Copy link

    @pavlovcik can I do this?

    @0x4007
    Copy link
    Member Author

    0x4007 commented Dec 26, 2023

    Sure just be sure to make it in typescript, using @octokit/rest, and it's executable using tsx.

    You will need to print test results as part of the pull request QA or it will not be accepted.

    @0x4007 0x4007 assigned EtherealGlow and unassigned b4s36t4 Dec 26, 2023
    @0x4007
    Copy link
    Member Author

    0x4007 commented Dec 28, 2023

    The spec states to parse permits not labels.

    @EtherealGlow
    Copy link

    how can i qa this, it seems mostly done just need to convert to a csv file

    @0x4007
    Copy link
    Member Author

    0x4007 commented Dec 28, 2023

    Just need to see results and they will be spot checked I don't understand the confusion

    @EtherealGlow
    Copy link

    Ubiquibot isn't working for me, I can't create test payment links for a test repo and scan them using this

    @0x4007
    Copy link
    Member Author

    0x4007 commented Dec 28, 2023

    There's plenty of permits that exist on the Ubiquity repositories. You don't need to generate any.

    @EtherealGlow
    Copy link

    heres what the command line tool gave me for this issue
    output (3).xlsx

    @0x4007
    Copy link
    Member Author

    0x4007 commented Dec 29, 2023

    Seems fine just ideally should link the original permit comment in the next column, then of course go through every repository in the ubiquity org. Also you should output csv

    @EtherealGlow
    Copy link

    EtherealGlow commented Dec 29, 2023

    I am assuming 3 minutes is a normal amount of time for scanning a entire repo as big as ubiquibot

    @EtherealGlow
    Copy link

    Also which repos do I have to scan (I have already scanned ubiquibot)

    @EtherealGlow
    Copy link

    ubiquibot.csv
    until then, heres the csv for the ubiquibot repo

    @0x4007
    Copy link
    Member Author

    0x4007 commented Dec 30, 2023

    ubiquibot.csv

    until then, heres the csv for the ubiquibot repo

    I think just link the comment instead of all those permits.

    You'll need to dynamically get every repo under ubiquity and compile the rewards.

    @EtherealGlow
    Copy link

    Aight wait a bit

    @0x4007
    Copy link
    Member Author

    0x4007 commented Jan 23, 2024

    You need to check your work before submitting it. I can't spend this much time clarifying instructions.

    This permit is not in your spreadsheet. ubiquity/business-development#38 (comment)

    @EtherealGlow
    Copy link

    i painstakingly checked the ones which werent assigned to any hunter, I am 90% sure that the ones that are not assigned to anyone is just because of the wallet addresses not being found

    @EtherealGlow
    Copy link

    output (4).csv

    @EtherealGlow
    Copy link

    @EtherealGlow
    Copy link

    @pavlovcik

    1 similar comment
    @EtherealGlow
    Copy link

    @pavlovcik

    @EtherealGlow
    Copy link

    Also I have a request, whenever you are free can you point out mistakes on how i work, I really want to get a internship by 16 so I wanna improve how I work

    @EtherealGlow
    Copy link

    It's been 10 days now

    @EtherealGlow
    Copy link

    😭

    @EtherealGlow
    Copy link

    @pavlovcik

    @EtherealGlow
    Copy link

    I get that I may request too many reviews, will test properly from now on wards but if it has annoyed you to the point of not reviewing, please forgive me.
    I am gonna make a script to see if all the permits that were not assigned were due to the reason of a unavailable wallet address

    @EtherealGlow
    Copy link

    @EtherealGlow
    Copy link

    I hope you can review it now 🙏🏼

    Copy link

    ubiquibot bot commented Feb 8, 2024

    # No linked pull requests to close

    @EtherealGlow
    Copy link

    ???

    @EtherealGlow
    Copy link

    Why did you unassign me

    @0x4007
    Copy link
    Member Author

    0x4007 commented Feb 8, 2024

    here are the test results https://github.com/EtherealGlow/ContributionTester/actions/runs/7779558930/job/21210897922

    There is no CSV of results that I could see there, and this error message doesn't look promising. https://github.com/EtherealGlow/ContributionTester/actions/runs/7779558930/job/21210897922#step:5:7

    I get that I may request too many reviews, will test properly from now on wards but if it has annoyed you to the point of not reviewing, please forgive me. I am gonna make a script to see if all the permits that were not assigned were due to the reason of a unavailable wallet address

    I estimated this could be done within a week. For myself, perhaps a few days of work. We're currently beyond two months from when you were assigned. You are disqualified from this continuing on this task.

    Also I have a request, whenever you are free can you point out mistakes on how i work, I really want to get a internship by 16 so I wanna improve how I work

    Bear in mind that like any core Ubiquity team member, I have other responsibilities aside from reviewing your pull requests. My advice to you would be to respect the time of others. Be sure to make the reviewer's job as easy as possible by 1. ensuring that your code works according to the issue specification 2. providing as much clearly written context/explanations with your work in the form of comments on the pull request 3. carefully following the rules at https://dao.ubq.fi/devpool

    It is not appreciated that you have continued to abuse our communication channels, such as other pull requests, and our public telegram group chat, by creating sybil accounts and prompting me to review this deliverable over several days.

    Conversation under issues should only be for clarifying the specification. Conversation under your pull request is where deliverable-related conversation occurs.

    I am only posting details (only related to you, and not the issue) here under the issue because you failed to follow the rules and did not link back another pull request with your latest work deliverable.

    If you do not follow the rules, the reviewers have no obligation to work with you.

    @ubiquity ubiquity deleted a comment from EtherealGlow Feb 8, 2024
    @ubiquity ubiquity deleted a comment from EtherealGlow Feb 8, 2024
    @EtherealGlow
    Copy link

    Please forgive me, I'll follow the rules from now on 🙏

    @EtherealGlow
    Copy link

    The test was for checking all the rouge permit comment links and to see if they weren't assigned to anyone because of missing addresses

    @EtherealGlow
    Copy link

    You can see in the latest CSV that everything's working correctly

    @EtherealGlow
    Copy link

    output (4).csv

    Around here

    @EtherealGlow
    Copy link

    Please let me continue on the task, I already contributed so much

    @EtherealGlow
    Copy link

    A whole repo and a pull request to fix issues on the repo

    @0x4007
    Copy link
    Member Author

    0x4007 commented Feb 8, 2024

    Closed for clutter on issue comments. Recreated at #95

    @0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
    Copy link

    ubiquibot bot commented Feb 8, 2024

    # Issue was not closed as completed. Skipping.

    @EtherealGlow
    Copy link

    So I can't?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.

    3 participants