-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UBQ Contributor Airdrop #90
Comments
@pavlovcik Would love to work on this. Can you explain more on this? |
Available commands
|
|
Cool, Will do that. |
/start |
Tips:
|
@pavlovcik can I do this? |
Sure just be sure to make it in typescript, using @octokit/rest, and it's executable using tsx. You will need to print test results as part of the pull request QA or it will not be accepted. |
The spec states to parse permits not labels. |
how can i qa this, it seems mostly done just need to convert to a csv file |
Just need to see results and they will be spot checked I don't understand the confusion |
Ubiquibot isn't working for me, I can't create test payment links for a test repo and scan them using this |
There's plenty of permits that exist on the Ubiquity repositories. You don't need to generate any. |
heres what the command line tool gave me for this issue |
Seems fine just ideally should link the original permit comment in the next column, then of course go through every repository in the ubiquity org. Also you should output csv |
I am assuming 3 minutes is a normal amount of time for scanning a entire repo as big as ubiquibot |
Also which repos do I have to scan (I have already scanned ubiquibot) |
ubiquibot.csv |
I think just link the comment instead of all those permits. You'll need to dynamically get every repo under ubiquity and compile the rewards. |
Aight wait a bit |
You need to check your work before submitting it. I can't spend this much time clarifying instructions. This permit is not in your spreadsheet. ubiquity/business-development#38 (comment) |
i painstakingly checked the ones which werent assigned to any hunter, I am 90% sure that the ones that are not assigned to anyone is just because of the wallet addresses not being found |
1 similar comment
Also I have a request, whenever you are free can you point out mistakes on how i work, I really want to get a internship by 16 so I wanna improve how I work |
It's been 10 days now |
😭 |
I get that I may request too many reviews, will test properly from now on wards but if it has annoyed you to the point of not reviewing, please forgive me. |
here are the test results |
I hope you can review it now 🙏🏼 |
# No linked pull requests to close |
??? |
Why did you unassign me |
There is no CSV of results that I could see there, and this error message doesn't look promising. https://github.com/EtherealGlow/ContributionTester/actions/runs/7779558930/job/21210897922#step:5:7
I estimated this could be done within a week. For myself, perhaps a few days of work. We're currently beyond two months from when you were assigned. You are disqualified from this continuing on this task.
Bear in mind that like any core Ubiquity team member, I have other responsibilities aside from reviewing your pull requests. My advice to you would be to respect the time of others. Be sure to make the reviewer's job as easy as possible by 1. ensuring that your code works according to the issue specification 2. providing as much clearly written context/explanations with your work in the form of comments on the pull request 3. carefully following the rules at https://dao.ubq.fi/devpool It is not appreciated that you have continued to abuse our communication channels, such as other pull requests, and our public telegram group chat, by creating sybil accounts and prompting me to review this deliverable over several days. Conversation under issues should only be for clarifying the specification. Conversation under your pull request is where deliverable-related conversation occurs. I am only posting details (only related to you, and not the issue) here under the issue because you failed to follow the rules and did not link back another pull request with your latest work deliverable. If you do not follow the rules, the reviewers have no obligation to work with you. |
Please forgive me, I'll follow the rules from now on 🙏 |
The test was for checking all the rouge permit comment links and to see if they weren't assigned to anyone because of missing addresses |
You can see in the latest CSV that everything's working correctly |
Around here |
Please let me continue on the task, I already contributed so much |
A whole repo and a pull request to fix issues on the repo |
Closed for clutter on issue comments. Recreated at #95 |
# Issue was not closed as completed. Skipping. |
So I can't? |
Make a command line tool that will tally up everybody's contributions from the last year.
We can parse all the permits generated across all of our repos and then drop 1 UBQ per dollar earned.
We should run this script when we enable UBQ token payouts
The text was updated successfully, but these errors were encountered: