Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #2

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Enhancements #2

merged 3 commits into from
Jan 2, 2024

Conversation

0x4007
Copy link
Contributor

@0x4007 0x4007 commented Jan 2, 2024

Resolves ubiquity/.github#90

  • Authentication for enhanced rate limits
  • Use yarn build
  • Enhanced logging

@0x4007
Copy link
Contributor Author

0x4007 commented Jan 2, 2024

I tested with slow internet so I couldn't complete the run in time. Will try again later but so far seems functional with authentication.

image

https://github.com/EtherealGlow/ContributionAnalyzer/pull/2/files#diff-12060c1ccac042edab175ad9fa0c53086a60c5d666978c11d00772ae379c2535R46

Alternative link: https://github.com/ubiquity/contribution-analyzer/blob/3f954c01f28a3da4901c53a87697c8e2473f16a4/src/helpers/calculateReward.ts#L46

This approach seems problematic. You should figure out a more robust way to test the comment for links to pay.ubq.fi because I don't believe that every permit has this exact header? Especially the older ones. Study those to confirm. But I assume that every permit since the beginning links to pay.ubq.fi

@0x4007
Copy link
Contributor Author

0x4007 commented Jan 2, 2024

You should handle this case. I have to log off my computer now.

Organization reward calculated successfully.
node:events:492
      throw er; // Unhandled 'error' event
      ^

Error: ENOENT: no such file or directory, open 'output/output.csv'
Emitted 'error' event on WriteStream instance at:
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'output/output.csv'
}

Node.js v20.10.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
m1:ContributionAnalyzer nv$

@EtherealGlow EtherealGlow merged commit f6d513a into EtherealGlow:development Jan 2, 2024
@EtherealGlow
Copy link
Owner

@pavlovcik i found the case that you were talking about
ubiquity/ubiquibot#268 (comment)

to fix this cant i just see first that if the comment contains task creator or conv rewards headers and give the reward to the respective person else it has to be a assignee reward and give it to the assignee

@EtherealGlow
Copy link
Owner

after pushing this commit you can see what i am talking about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UBQ Contributor Airdrop
2 participants