Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved logs #226

Merged
merged 30 commits into from
Jan 9, 2025
Merged

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Dec 29, 2024

Resolves #209

Example of logs:
image

No logic has been changed but readability of the logs is greatly improved, which should help debugging deployed versions of the kernel.

@gentlementlegen gentlementlegen marked this pull request as ready for review January 4, 2025 14:20
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be using our logger method instead of console

@gentlementlegen
Copy link
Member Author

@0x4007 #181

src/github/utils/config.ts Show resolved Hide resolved
@gentlementlegen
Copy link
Member Author

@whilefoo made the requested changes and added the displays of ratelimit to see if that helps. There is no way to see the secondary rate limit quota however. https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#exceeding-the-rate-limit

Will fix the formatting and tests.

@gentlementlegen gentlementlegen merged commit 32996e5 into ubiquity-os:development Jan 9, 2025
3 checks passed
@gentlementlegen gentlementlegen deleted the fix/logs branch January 9, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not log "manifest not found" as errors
3 participants