Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update octokit method calls to use the rest API #97

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Oct 31, 2024

Ensure that the rest calls of Octokit are used. @rndquu RFC, no logic has changed besides that.

Migrated to octokit.rest for users, repos, and issues methods.
Switch `users` to `rest.users` in ERC721 and ERC20 tests.
@gentlementlegen gentlementlegen merged commit 961ebeb into ubiquity-os:development Oct 31, 2024
2 checks passed
@rndquu
Copy link
Member

rndquu commented Oct 31, 2024

Ensure that the rest calls of Octokit are used. @rndquu RFC, no logic has changed besides that.

  1. octokit.users.getByUsername()
  2. octokit.rest.users.getByUsername()

The difference between the lines above is that in the 1st case graphql API may be used?

Copy link

! Error: HttpError: Resource not accessible by integration - https://docs.github.com/rest/issues/comments#create-an-issue-comment

@gentlementlegen
Copy link
Member Author

The rest is the modern way to use Octokit. The other way will be deprecated from what I've read. Our packages use the modern way (so does the SDK) so the octokit instance has to be used that way otherwise the methods don't exist. Octokit.graphql is also available indeed.

Copy link

! Error: HttpError: Resource not accessible by integration - https://docs.github.com/rest/issues/comments#create-an-issue-comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants