Merge pull request #180 from gentlementlegen/fix/zero-display

CHANGELOG.md

@@ -2,17 +2,16 @@
 
 ## [1.5.1](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/compare/v1.5.0...v1.5.1) (2024-10-12)
 
-
 ### Bug Fixes
 
-* add log message for closed pull requests ([d640681](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/d640681cbcbbf5961e61c4f41eec8b82d963444d))
-* add logging for payload truncation ([bf0f4c5](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/bf0f4c5f6aaa8714baf8e4653f36f275f695374f))
-* added custom configuration and related tests ([2fc8136](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/2fc8136813c94553cc1631d50b87901831405484))
-* downgrade ethers to 5.7.2 and update web3 helper ([c5e8e3c](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/c5e8e3c0877bd21e80d745bdae557d28c74bd7f4))
-* enhance error logging for missing multiplier cases ([a8cab80](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/a8cab808e30cd1e156e795de22a63a386c39c591))
-* enhance error logging for missing multiplier cases ([72d0d47](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/72d0d4711eec68f7880e95762ccb5a853cf2299a))
-* remove redundant console log in run.ts ([7851b75](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/7851b7524822c42b62e1c67dca4a00bcbe9d7f4f))
-* upgrade permit generation package ([5300022](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/5300022f2b45d0d1b5c48b2d0db46014a5643bf5))
+- add log message for closed pull requests ([d640681](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/d640681cbcbbf5961e61c4f41eec8b82d963444d))
+- add logging for payload truncation ([bf0f4c5](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/bf0f4c5f6aaa8714baf8e4653f36f275f695374f))
+- added custom configuration and related tests ([2fc8136](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/2fc8136813c94553cc1631d50b87901831405484))
+- downgrade ethers to 5.7.2 and update web3 helper ([c5e8e3c](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/c5e8e3c0877bd21e80d745bdae557d28c74bd7f4))
+- enhance error logging for missing multiplier cases ([a8cab80](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/a8cab808e30cd1e156e795de22a63a386c39c591))
+- enhance error logging for missing multiplier cases ([72d0d47](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/72d0d4711eec68f7880e95762ccb5a853cf2299a))
+- remove redundant console log in run.ts ([7851b75](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/7851b7524822c42b62e1c67dca4a00bcbe9d7f4f))
+- upgrade permit generation package ([5300022](https://github.com/ubiquity-os-marketplace/text-conversation-rewards/commit/5300022f2b45d0d1b5c48b2d0db46014a5643bf5))
 
 ## [1.5.0](https://github.com/ubiquity-os-marketplace/conversation-rewards/compare/v1.4.0...v1.5.0) (2024-09-30)
 

src/parser/github-comment-module.ts

@@ -241,8 +241,8 @@ export class GithubCommentModule implements Module {
               <pre>${formatting}</pre>
              </details>
             </td>
-            <td>${commentScore.score?.relevance ?? "-"}</td>
-            <td>${commentScore.score?.reward ?? "-"}</td>
+            <td>${commentScore.score?.relevance === undefined ? "-" : commentScore.score.relevance}</td>
+            <td>${commentScore.score?.reward === undefined ? "-" : commentScore.score.reward}</td>
           </tr>`;
     }
 
@@ -293,7 +293,7 @@ export class GithubCommentModule implements Module {
           </h6>
         </b>
       </summary>
-      ${result.feeRate !== undefined ? `<h6>⚠️ ${new Decimal(result.feeRate).mul(100)}% fee rate has been applied. Consider using the <a href="https://dao.ubq.fi/dollar" target="_blank" rel="noopener">Ubiquity Dollar</a> for no fees.</h6>` : ""}
+      ${result.feeRate !== undefined ? `<h6>⚠️ ${new Decimal(result.feeRate).mul(100)}% fee rate has been applied. Consider using the&nbsp;<a href="https://dao.ubq.fi/dollar" target="_blank" rel="noopener">Ubiquity Dollar</a>&nbsp;for no fees.</h6>` : ""}
       <h6>Contributions Overview</h6>
       <table>
         <thead>

tests/fees.test.ts

@@ -76,7 +76,7 @@ describe("GithubCommentModule Fee Tests", () => {
     const bodyContent = await githubCommentModule.getBodyContent(result);
 
     expect(bodyContent).toEqual(
-      '<details><summary><b><h3>&nbsp;<a href="https://pay.ubq.fi" target="_blank" rel="noopener">[ 100 WXDAI ]</a>&nbsp;</h3><h6>@ubiquity-os</h6></b></summary><h6>⚠️ 20% fee rate has been applied. Consider using the<a href="https://dao.ubq.fi/dollar" target="_blank" rel="noopener">Ubiquity Dollar</a>for no fees.</h6><h6>Contributions Overview</h6><table><thead><tr><th>View</th><th>Contribution</th><th>Count</th><th>Reward</th></tr></thead><tbody><tr><td>Issue</td><td>Task</td><td>1.5</td><td>50</td></tr></tbody></table><h6>Conversation Incentives</h6><table><thead><tr><th>Comment</th><th>Formatting</th><th>Relevance</th><th>Reward</th></tr></thead><tbody></tbody></table></details>\n' +
+      '<details><summary><b><h3>&nbsp;<a href="https://pay.ubq.fi" target="_blank" rel="noopener">[ 100 WXDAI ]</a>&nbsp;</h3><h6>@ubiquity-os</h6></b></summary><h6>⚠️ 20% fee rate has been applied. Consider using the&nbsp;<a href="https://dao.ubq.fi/dollar" target="_blank" rel="noopener">Ubiquity Dollar</a>&nbsp;for no fees.</h6><h6>Contributions Overview</h6><table><thead><tr><th>View</th><th>Contribution</th><th>Count</th><th>Reward</th></tr></thead><tbody><tr><td>Issue</td><td>Task</td><td>1.5</td><td>50</td></tr></tbody></table><h6>Conversation Incentives</h6><table><thead><tr><th>Comment</th><th>Formatting</th><th>Relevance</th><th>Reward</th></tr></thead><tbody></tbody></table></details>\n' +
         "<!-- Ubiquity - GithubCommentModule - GithubCommentModule._callee$ - 1234\n" +
         "{\n" +
         '  "workflowUrl": "https://github.com/ubiquity-os/conversation-rewards/actions/runs/1",\n' +