fix: remove allow command #66
Conversation
Unused devDependencies (1)
|
|
@whilefoo by removing the |
|
The plugin also saves label changes (not issue label but actual label name change) but I can't remember why we did that (maybe for audit?) but if we remove that then we don't need supabase |
|
Never heard or used the capability before so I am not sure if it is needed / wanted. @0x4007 thoughts? |
|
I'm on board for removing supabase dependencies by default. Also, I don't recall this feature so it's probably one of many deprecated database dependent features |
|
@gentlementlegen, this task has been idle for a while. Please provide an update. |
|
@0x4007 If you can review it thx! |
|
@gentlementlegen, this task has been idle for a while. Please provide an update. |
|
@0x4007 😄 |
|
|
||
| createActionsPlugin<AssistivePricingSettings, Env, Command, SupportedEvents>( | ||
| createActionsPlugin<AssistivePricingSettings, Env, null, SupportedEvents>( |
There was a problem hiding this comment.
It makes sense to me to make null the last typing here so that it's optional to pass in, right?
There was a problem hiding this comment.
It is part of the SDK, so should require a change there. Rfc @whilefoo
There was a problem hiding this comment.
sure we can put it as last optional argument
|
@gentlementlegen, this task has been idle for a while. Please provide an update. |
|
@0x4007 If you can have a look thanks. |
Resolves #62
Depends on #65
QA: Meniole#8