feat/label-gating #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting/development # Conflicts: # manifest.json # src/types/plugin-input.ts # src/worker.ts # tests/main.test.ts
rename workflow and integrate build step, refactor node setup and plugin deployment.
Refactor label handling to utilize 'value' property for time labels.
Enabled label description in createLabel function.
Updated label handling to consistently use 'name' property instead of 'value'.
Correct the logic for filtering incorrect price labels.
0x4007
reviewed
Oct 10, 2024
# Conflicts: # dist/index.js
Co-authored-by: アレクサンダー.eth <[email protected]>
Add a log statement to track label update checks, improving traceability.
Introduced getLabelsChanges function to detect label changes in global config updates.
Changed logger imports from @ubiquity-dao/ubiquibot-logger to @ubiquity-os/ubiquity-os-logger
|
Made a suggestion in regards to this feature in the Task mate that will clear you of the grief and hassle of waiting for me or #18 Haven't slept, going to try get some now and I'll push #18 through when I wake but my suggestion is literally a < 15 min change in I don't want to be a blocker and also trying to provide more solutions than problems. |
Replace GPG_PRIVATE_KEY with APP_ID and APP_PRIVATE_KEY in deploy step.
Cleaned up compute.yml by removing echo and unnecessary setup steps.
Removed the "type": "module" from package.json and downgraded TypeScript
Added `@ts-expect-error`
…ions Include PLUGIN_GITHUB_TOKEN in compute.yml environment variables
Grouped time and priority labels for better structure in README.
Upgraded various dependencies, including Supabase to ^1.207.9
Update label descriptions to use empty strings instead of undefined
Switch from jest.mock to jest.unstable_mockModule
Extend timeout to 15 seconds to prevent test timeouts in price-labels.test.ts.
Included the KERNEL_PUBLIC_KEY secret to enhance security in workflows.
Catch and log 404 errors for missing labels to prevent unnecessary exceptions while updating labels.
|
@Keyrxng feel free to review if you have some time. |
0x4007
reviewed
Nov 1, 2024
0x4007
reviewed
Nov 1, 2024
Condensed parameter declarations into a single line for readability.
gentlementlegen
merged commit 01a28b7
into
ubiquity-os-marketplace:development
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ubiquity-os-marketplace/command-start-stop#62
Depends on #18
QA: Meniole#6
https://github.com/Meniole/daemon-pricing/actions/runs/11569584860/job/32203588418