-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: task limit #91
fix: task limit #91
Conversation
Reordered imports for better readability and optimized async.
@gentlementlegen, this task has been idle for a while. Please provide an update. |
Unlisted dependencies (1)
|
# Conflicts: # manifest.json # package.json # yarn.lock
Added hono version 4.6.12 to package.json and updated yarn.lock accordingly.
# Conflicts: # .github/workflows/update-configuration.yml # dist/index.js # yarn.lock
@whilefoo Could you please also have a look? |
Your QA isn't clear can you list the three scenarios and their outputs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine I just wish the QA was more clear.
@@ -39,7 +39,7 @@ function maxConcurrentTasks() { | |||
|
|||
export const pluginSettingsSchema = T.Object( | |||
{ | |||
reviewDelayTolerance: T.String({ default: "1 Day" }), | |||
reviewDelayTolerance: T.String({ default: "1 Day", description: "How long shall the wait be for a reviewer to take action?" }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description isn't very clear. Given the specification, I guess that this should describe the max time we will wait for a reviewer to review while holding up the task for the assignee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like "Duration delay for a pull-request to count against the user's maximum assigned issues quota" ?
@0x4007 It is hard to do a clear QA because it depends on a pull-request review. So I had to ask for review, test after idle on a review, or after a comment. The linked review is Meniole#42 |
Then let's test in prod |
Resolves #28
Depends on #86
QA: Meniole#48
What are the changes