Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: task limit #91

Merged

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Nov 22, 2024

Resolves #28
Depends on #86

QA: Meniole#48

What are the changes

  • if a PR has a change requested, counts as -1
  • if a PR was opened with no reviews, either -1 is less than the review threshold or +1 if passed
  • if a PR has approved status (without any other required changes), +1
  • if a PR was reviewed, changed, then review requested again, either -1 is less than the review threshold or +1 if passed

gentlementlegen and others added 2 commits November 22, 2024 15:55
Copy link

@gentlementlegen, this task has been idle for a while. Please provide an update.

Copy link
Contributor

Unlisted dependencies (1)

Filename unlisted
src/index.ts hono

@gentlementlegen gentlementlegen changed the base branch from development to main November 26, 2024 10:39
@gentlementlegen gentlementlegen changed the base branch from main to development November 26, 2024 10:39
@gentlementlegen gentlementlegen marked this pull request as ready for review November 26, 2024 16:00
@gentlementlegen
Copy link
Member Author

@whilefoo Could you please also have a look?

@0x4007
Copy link
Member

0x4007 commented Nov 27, 2024

Your QA isn't clear can you list the three scenarios and their outputs?

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine I just wish the QA was more clear.

@@ -39,7 +39,7 @@ function maxConcurrentTasks() {

export const pluginSettingsSchema = T.Object(
{
reviewDelayTolerance: T.String({ default: "1 Day" }),
reviewDelayTolerance: T.String({ default: "1 Day", description: "How long shall the wait be for a reviewer to take action?" }),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description isn't very clear. Given the specification, I guess that this should describe the max time we will wait for a reviewer to review while holding up the task for the assignee

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like "Duration delay for a pull-request to count against the user's maximum assigned issues quota" ?

@gentlementlegen
Copy link
Member Author

@0x4007 It is hard to do a clear QA because it depends on a pull-request review. So I had to ask for review, test after idle on a review, or after a comment. The linked review is Meniole#42

@0x4007
Copy link
Member

0x4007 commented Nov 27, 2024

Then let's test in prod

@0x4007 0x4007 merged commit 45a0726 into ubiquity-os-marketplace:development Nov 27, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the fix/task-limit branch November 27, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly handle task limit
2 participants