Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure assignee is checked in userUnassigned handler #77

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Nov 4, 2024

Resolves #74
QA: Meniole#45

Check `assignee` before closing pull requests to avoid errors.
@gentlementlegen gentlementlegen marked this pull request as ready for review November 4, 2024 15:13
@gentlementlegen
Copy link
Member Author

@Keyrxng if you want to take a look.

Added a check to skip message posting if the sender is a bot.
Changed compatibility_date and added compatibility_flags for Node.js.
Copy link
Contributor

@Keyrxng Keyrxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as intended.

Previous problem was the sender was used to check for PRs now assignee is used which makes sense

@gentlementlegen gentlementlegen merged commit 0480ab3 into ubiquity-os-marketplace:development Nov 9, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the fix/close-prs branch November 9, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User un-assign should close its linked pull-requests
2 participants