-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Self Assigns #13
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { Context } from "../../types"; | ||
|
||
export async function wasPreviouslyUnassigned( | ||
context: Context, | ||
senderLogin: Context["payload"]["sender"], | ||
issueNumber: Context["payload"]["issue"] | ||
): Promise<boolean> { | ||
try { | ||
const issueEvents = await context.octokit.issues.listEventsForTimeline({ | ||
owner: context.payload.repository.owner.login, | ||
repo: context.payload.repository.name, | ||
issue_number: issueNumber.id, | ||
}); | ||
|
||
return issueEvents.data.some((event) => event.event === "unassigned" && event.event === senderLogin); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm sceptical that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just noticed that this fails on the test CI. I suppose I should be more cautious of reviews from mobile as it is not easy to see these details sometimes. |
||
} catch (error) { | ||
console.error("Error while checking previous assignment:", error); | ||
return false; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming convention for these args is off slightly so it's being used in error in the return statement below I think