change internal links in bioconda posts #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexylena
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
TIL about post_url that's very convenient!
I tested this locally and realised that checking by hand was a bit silly when we have automated means :) So I ran lychee locally and found a couple missed links (4fe3aab) and a bad image url (81d0aea) so I've added it to our pull request build process, not only do we check if the site builds, but we also check that every internal link (including e.g. opengraph metadata) works on every PR.
I don't think contributors need to run lychee locally as it can just run in github actions, it can more or less be ignored until a build fails because of a bad link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the internal links in the bioconda posts so that they generate URLs with .html extension