-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'how to add a bioconda recipe and biocontainer' tutorial #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here mostly just commenting on some typos and language fixes.
Fantastic work @jfy133! I successfully submitted I've add a few minor comments/suggestions. Only major gripe would be that it's very long and I feel like I didn't need it all i.e. I was adding a package from PYPI so most of the R/build.sh steps were irrelevant. I'm not sure if there's a way to break this up into package types? e.g. only show some sections if they are applicable. (the TLDR is good tho) |
|
||
```bash | ||
cd recipes/ | ||
greyskull <pypi/cran> > <toolname>/meta.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
greyskull <pypi/cran> > <toolname>/meta.yaml | |
greyskull <pypi/cran> <toolname> > <toolname>/meta.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
greyskull pypi: error: the following arguments are required: pypi_packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also once I ran greyskull it added a bunch of \u0000
values to the end of the meta.yaml file which then failed linting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting... I also don't get the 'following arguments' error, not \u000 with the new command I will be pushing... maybe you can try that
Woohoo thank you! Addressed all the minor comments :) Indeed, I did wonder if it would make sense to split it up into three posts: adding a recipe, debugging, and updating, what do you think? I see what you mean about the build.sh steps not being relevant, but I don't think there is sufficient difference between the types for it to make sense (there is basically python/(some) R, and everything else)... I guess I could see if the |
Unfortunately the I'm erring on keeping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's time to merge it!
Opening this already so people can shame me into finishing it (will be slow going for a while because baby).
I'm basically cleaning up these notes: https://hackmd.io/@jfy133/ryXNpa9Op
At the end I'll make a fast TL;DR version too probably