Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post: Switch to bam #30

Merged
merged 44 commits into from
Jun 6, 2024
Merged

Post: Switch to bam #30

merged 44 commits into from
Jun 6, 2024

Conversation

lskatz
Copy link
Contributor

@lskatz lskatz commented May 30, 2024 •
edited
Loading

This is a call to action for people to switch from fastq to bam across the board.

@lskatz lskatz requested a review from a team as a code owner May 30, 2024 17:16
hexylena
hexylena reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice call to action!

I wonder if we should pair it up with issues filed against the repositories for each of those tools or pipelines, because support for that would be lovely.

_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
pmenzel
pmenzel reviewed Jun 4, 2024
View reviewed changes
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
lskatz
lskatz commented Jun 4, 2024
View reviewed changes
Copy link
Contributor Author

@lskatz lskatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added pmenzel's excellent revisions

_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
@lskatz
Copy link
Contributor Author

lskatz commented Jun 4, 2024

Added pmenzel's excellent revisions

Sorry that was supposed to be a commit; please ignore.

pmenzel
pmenzel previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@pmenzel pmenzel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes, otherwise it's good to go, once the Illumina thingy is resolved!

_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
_posts/2024-05-14-switch-to-bam.md Outdated Show resolved Hide resolved
@lskatz
Copy link
Contributor Author

lskatz commented Jun 5, 2024

I wonder if we should pair it up with issues filed against the repositories for each of those tools or pipelines, because support for that would be lovely.

This would have been very interesting but so far I don't see any github issues discussions about using uBAM input

pmenzel
pmenzel previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@pmenzel pmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go

@pmenzel pmenzel merged commit e1c067c into ubinfie:main Jun 6, 2024
1 check passed
@lskatz lskatz deleted the switch-to-bam branch June 6, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexylena hexylena hexylena left review comments

@pmenzel pmenzel pmenzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lskatz @hexylena @pmenzel