Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test function to check relaxdriver #47

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Conversation

kzqureshi
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (37b6673) to head (9960867).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           14        14           
=========================================
  Hits            14        14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@swapneelap swapneelap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a few questions regarding the changes. Further, do you think we will need to update the tests (maybe conftest.py) in oommfc as the relax driver is not implemented(?) there?

micromagnetictests/calculatortests/relaxdriver.py Outdated Show resolved Hide resolved
micromagnetictests/calculatortests/relaxdriver.py Outdated Show resolved Hide resolved
kzqureshi added a commit to ubermag/oommfc that referenced this pull request Feb 27, 2024
ubermag/micromagnetictests#47 introduces additional tests for the
relax driver which is not supported in oommf.
@samjrholt samjrholt merged commit 89829b0 into master Mar 1, 2024
9 checks passed
@samjrholt samjrholt deleted the test_for_relax_driver branch March 1, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants