Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the field test for bool type #1480

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

rleungx
Copy link
Contributor

@rleungx rleungx commented Jan 6, 2025

Just as the title says.

Signed-off-by: Ryan Leung <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jan 6, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abhinav abhinav requested a review from sywhang January 6, 2025 13:11
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (fe16eb5) to head (5832eea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1480      +/-   ##
==========================================
+ Coverage   98.45%   98.59%   +0.14%     
==========================================
  Files          53       53              
  Lines        3562     3562              
==========================================
+ Hits         3507     3512       +5     
+ Misses         46       42       -4     
+ Partials        9        8       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sywhang sywhang merged commit 32f2ec1 into uber-go:master Jan 7, 2025
8 checks passed
@rleungx rleungx deleted the fix-test branch January 8, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants