-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Test with Go 1.22 #1409
ci: Test with Go 1.22 #1409
Conversation
Maybe add something like ">=1.22.0-rc.2"? Then any latest version will be tested |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
+ Coverage 98.42% 98.44% +0.01%
==========================================
Files 53 53
Lines 3495 3527 +32
==========================================
+ Hits 3440 3472 +32
Misses 46 46
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Once Go1.22 is GA, will change to 1.22.x. |
Thanks for the PR, @arukiidou! |
I use such a matrix to check the work in the beta version, but not blocking the work of CI strategy:
matrix:
go: ["1.20.x", "1.21.x"]
continueOnError: [false]
include:
- go: ">=1.22.0-rc.1"
continueOnError: true |
passed in Go1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Should these also be Go1.21 bumped?
I don't think these changes should occur in this PR - we can bump it to Go 1.20 to be safe, since starting from Go 1.21 the go module version is the minimum required version for the project to work as expected which isn't the case. That can be a separate discussion, though.
Thank you! |
With the release of Go 1.22,
CI should run against Go 1.21 and 1.22