-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend support for Equal
in trusted func framework
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 89.23% 89.32% +0.09%
==========================================
Files 53 53
Lines 8016 8048 +32
==========================================
+ Hits 7153 7189 +36
+ Misses 716 712 -4
Partials 147 147
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sonalmahajan15
force-pushed
the
sonalmahajan15/fix-trusted-func-equal
branch
from
October 11, 2023 16:23
058ef01
to
90b5a42
Compare
yuxincs
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM module a few nits that do not necessarily have to be fixed 😃 .
yuxincs
reviewed
Oct 16, 2023
sonalmahajan15
force-pushed
the
sonalmahajan15/fix-trusted-func-equal
branch
from
October 17, 2023 18:29
588c61a
to
9a5bbf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equal
support was limited to only handling slice length comparison (e.g.,Equal(0, len(s))
). This PR extends thisEqual
support also handle nil comparisons (e.g.,Equal(nil, err)
). Specifically, this PR makes the following changes:requireComparators
code to accommodate the extensionrequireComparators
NotEqual
in trusted funcs list and specific test cases for the slice comparison case as well[Closes #64 ]