Sort upstream facts based on package paths #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 89.23% 89.27% +0.03%
==========================================
Files 54 54
Lines 8233 8239 +6
==========================================
+ Hits 7347 7355 +8
+ Misses 728 727 -1
+ Partials 158 157 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yuxincs
force-pushed
the
yuxincs/use-ordered-map-for-inferred-map
branch
from
d745880 to
658582b
Compare
yuxincs
force-pushed
the
yuxincs/sort-upstream-facts
branch
from
ec3931c to
f06151d
Compare
yuxincs
force-pushed
the
yuxincs/use-ordered-map-for-inferred-map
branch
from
658582b to
c0f0e58
Compare
yuxincs
force-pushed
the
yuxincs/sort-upstream-facts
branch
from
f06151d to
314845f
Compare
yuxincs
force-pushed
the
yuxincs/use-ordered-map-for-inferred-map
branch
from
c0f0e58 to
cec86d2
Compare
yuxincs
force-pushed
the
yuxincs/sort-upstream-facts
branch
from
314845f to
36832a1
Compare
yuxincs
force-pushed
the
yuxincs/use-ordered-map-for-inferred-map
branch
from
cec86d2 to
830bd2b
Compare
yuxincs
force-pushed
the
yuxincs/sort-upstream-facts
branch
from
36832a1 to
58fe1b5
Compare
yuxincs
force-pushed
the
yuxincs/use-ordered-map-for-inferred-map
branch
from
830bd2b to
dc0e5a7
Compare
yuxincs
force-pushed
the
yuxincs/sort-upstream-facts
branch
from
58fe1b5 to
3ebe927
Compare
yuxincs
force-pushed
the
yuxincs/use-ordered-map-for-inferred-map
branch
from
dc0e5a7 to
3782547
Compare
Base automatically changed from
yuxincs/use-ordered-map-for-inferred-map
to
main
October 31, 2023 15:21
yuxincs
force-pushed
the
yuxincs/sort-upstream-facts
branch
from
3ebe927 to
73181c5
Compare
yuxincs
added a commit
that referenced
this pull request
Oct 31, 2023
This PR fixes two panics due to the assumption that the RHS of the global variable assignments are always variables, which isn't true when RHS is a constant (either defined in the current package, or referenced from upstream package) We also take this opportunity to refactor the code a little bit to be more readable and maintainable. Depends on #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are calling
analysis.Pass.AllPackageFacts()API from the analysis framework to import NilAway facts from upstream dependencies. However, this API is documented asIn some drivers such as nogo, this order is deterministic, however, in most other drives like the one from the
analysisframeowork, the order will be nondeterministic.Therefore, for determinism in NilAway, this PR sorts imported upstream facts (i.e.,
inference.InferredMap) based on the package path.Depends on PR #67