Generalize trusted function framework to be a hook framework #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 63 63
Lines 7916 7916
=======================================
Hits 6935 6935
Misses 799 799
Partials 182 182 ☔ View full report in Codecov by Sentry. |
sonalmahajan15
approved these changes
Sep 30, 2024
yuxincs
added a commit
that referenced
this pull request
Oct 5, 2024
We do not really have custom nilable types for a really long time now, so it makes sense to remove the dead code. If we ever want to add such custom nilable types again, we should consider adding a hook here via the hook framework (#278).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the trusted function framework to be a NilAway-wide hook framework.
To be honest it was already a NilAway-wide thing: it hooks into different parts of the system and can do different actions based on certain conditions. This PR simply lifts it up to the root level and call it "hook" instead of trusted function: in the future we may leverage this framework to handle more than function calls, with more types of actions, and hooking into more points (e.g., even in inference).
This PR is the first of a series of PRs to generalize this framework: this one simply does the relocation with no changes other than reference updates.