Delete unused String() methods
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 89.01% 89.38% +0.37%
==========================================
Files 55 55
Lines 9176 9138 -38
==========================================
Hits 8168 8168
+ Misses 841 803 -38
Partials 167 167 ☔ View full report in Codecov by Sentry. |
yuxincs
approved these changes
Dec 27, 2023
| @@ -137,11 +130,6 @@ func (r *okRead) effectIfFalse(*RootAssertionNode) { | |||
|
|
|||
| func (*okRead) isNoop() bool { return false } | |||
|
|
|||
| func (r *okRead) String() string { | |||
| return fmt.Sprintf("<okRead: {value: %s, ok: %s}>", | |||
| r.value.MinimalString(), r.ok.MinimalString()) | |||
There was a problem hiding this comment.
qq: Are we still using MinimalString?
sonalmahajan15
force-pushed
the
sonalmahajan15/delete-string
branch
from
78686b5 to
f5ac200
Compare
sonalmahajan15
added a commit
that referenced
this pull request
Feb 8, 2024
This pull request introduces support for the `ok` form in both user-defined and library functions and methods. The implementation addresses false positives, such as those identified in issue #77. Currently, the feature is designed to handle explicit boolean returns, specifically in the form of `return r0, r1, ..., true`. Support for expression-based returns (e.g., `return r0, r1, ..., flag` or `return r0, r1, ..., isOk()`) is tricky, as tracking boolean types is currently not supported in NilAway. We can handle this scenario in the future. [Closes #77 ] [Depends on #156 ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs code cleanup by deleting unused
String()methods.