-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve mock usability in tests #110
Conversation
feldentm-SAP
commented
Oct 13, 2023
Add stacktrace on fatal exit of mocked call to allow maintainers of tests using this API to understand what is actually going wrong
migrate PR from golang/mock#680 |
@JacobOaks I consider this change a bug fix and would be allowed to donate it to the project without signing the CLA. Signing an Uber CLA is currently not that easy. |
Hi @feldentm-SAP - looks like Github is intent on closing this PR on my behalf for some reason (I did not close this and when I try to re-open it immediately closes it). Let me look into it |
@JacobOaks, to whom may I forward the executed copy of the CLA? |
I managed to progress on the legal side, but are now facing technical issues with signing the CLA. |
@JacobOaks do you know why I'm not allowed to reopen this PR? do you have an idea why I'm presented an empty CLA UI with no means to sign anything? |
@JacobOaks I finally managed to sign the CLA and would love this PR to get merged |
@JacobOaks thanks for trying, but I created an identical PR in the meantime to work around this issue: #145 |