-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JSON serialization and deserialization of atomic.Time #125
base: master
Are you sure you want to change the base?
Conversation
Fixes #124 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should implement MarshalText
instead, since the JSON encoding of a time is a string, and MarshalText
will work in more cases, and matches atomic.String
better.
Agreed, that does make more sense. |
@prashantv My apologies for the delay, I've updated the PR with the latest comments in mind. |
Before opening your pull request, please make sure that you've:
make test
); and finally,make lint
).Thanks for your contribution!