-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Re arch support extra ops #109
Open
mbartling
wants to merge
11
commits into
develop
Choose a base branch
from
re-arch-support-extra-ops
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mbartling
commented
May 12, 2020
- Add additional operator support for target rearch.
- Fix bug in TFLITE parser where all tensors are treated as having quantization params.
- Add placeholder list for TF Lite side parser, so we can clarify and differentiate between frontend Op support and Backend Op support
dboyliao
requested changes
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the namespaces for the _Operator
s.
Also, you need to properly lower the ops such as updating op_info.code_gen_attributes['namespaces']
.
Of course, the conflicts need to be resolved too.
Done |
…r_cgen into re-arch-support-extra-ops
mbartling
force-pushed
the
re-arch-support-extra-ops
branch
from
June 12, 2020 21:06
e79e647
to
b2b356e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.