-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Refactoring & Fix issue on nvim #101
base: master
Are you sure you want to change the base?
Conversation
It fixes "neovim's system does not support background..." issue
Web.HTTP still require Process module
I'll fix tests later. Btw, the behavior was tested only in macOS Sierra so it should be tested in other platform as well. |
@@ -523,21 +520,17 @@ function! openbrowser#__open_browser__(uristr) "{{{ | |||
return 0 | |||
endfunction "}}} | |||
|
|||
function! openbrowser#__system__(...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing this function, please use s:Process.execute()
in this function.
It should also pass failed tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@lambdalisue Does this PR fix #102 too? |
ping |
Yes but to support neovim correctly, it should use |
@lambdalisue hm, like this? (I don't know if -let s:Process = vital#openbrowser#import('System.Process')
+let s:Process = vital#openbrowser#import('System.Process.Job') |
We have to wait vim-jp/vital.vim#513 |
@lambdalisue Okay. I made a workaround about this in #104. |
So would you want to wait |
Yes. |
Ok! |
#98 (comment)
vim-jp/vital.vim#533