Add a memoizedAcquire method to Resource
#4105
Conversation
| val fa2 = F.uncancelable { poll => | ||
| poll(allocatedCase).flatMap { case (a, r) => release.update(r :: _).as(a) } | ||
| } | ||
| Resource.makeCaseFull[F, F[B]](poll => poll(F.memoize(fa2)).map(_.widen)) { (_, exit) => |
There was a problem hiding this comment.
@durban @armanbilge I applied the change here, to ensure acquisition will not be cancelled once F.memoize(fa2) has been successfully run. I tried to come up with a test to ensure the behavior but could not find any reliable way to write something that tries to cancel it at the right time.
Do you have an idea on how I could write such a test?
There was a problem hiding this comment.
Do you have an idea on how I could write such a test?
#3425 is an example of a similar PR. Notice the special use of the test runtime.
TestControl.executeEmbed(go, IORuntimeConfig(1, 2))Further reading:
There was a problem hiding this comment.
Thanks, I will have a look at this.
djspiewak
changed the title
memoizedAcquire method to ResourcememoizedAcquire method to Resource
|
I did not forget about this PR. Testing it is currently blocked by the |
As mentioned in #3890 (comment), this is the PR taking over #3890 to add a specialized version of
memoizedforResource.Ref #3513