-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mdoc
guards to test-runtime.md.
#4097
base: series/3.5.x
Are you sure you want to change the base?
Conversation
@kamilkloch I think the error might be due to the fact that munit-cats-effect 2.0.0 is released against Scala 3.3.3, while the Scala 3 build here is against 3.2.2. |
Thank you for the valuable hint! Is there any way a develper can see the min required Scala 3 version on an artifact? No hint in maven: https://mvnrepository.com/artifact/org.typelevel/munit-cats-effect_3/2.0.0 |
|
@mzuehlke Thank you!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, however due to the issues mentioned this is probably a better candidate for the munit-cats-effect repository?
.dependsOn(core.jvm, testkit.jvm) | ||
.enablePlugins(MdocPlugin) | ||
.settings( | ||
libraryDependencies += "org.typelevel" %% "munit-cats-effect" % "2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately it would be bad practice add this dependency to the Cats Effect build. This will create a cycle: munit-cats-effect depends on cats-effect. So then we might not be able to update cats-effect without first updating munit-cats-effect, but we wouldn't be able to update munit-cats-effect without first updating cats-effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we update first munit-cats-effect! 🧌
Fixes #4095.