Skip to content

Commit

Permalink
Remove references to yarn, and don't try to format yaml files with pr…
Browse files Browse the repository at this point in the history
…ettier
  • Loading branch information
NullVoxPopuli committed Jan 5, 2024
1 parent d5b45fe commit af9f714
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 15 deletions.
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,5 @@ dist/
# the formatting applied by Gitbook. Having both present is a recipe for ongoing
# CI problems.
*.md
*.yml
*.yaml
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ We welcome contributions to Glint! To help us help you be successful, please fol

## Working on the project

Glint is a family of packages which all live in this repo as a Yarn workspace. To be most successful here, you should:
Glint is a family of packages which all live in this repo as a pnpm workspace. To be most successful here, you should:

- Install [Volta](https://volta.sh), a JavaScript toolchain manager we use to make sure everyone working on the project is using the same versions of Node and Yarn.
- Install [Volta](https://volta.sh), a JavaScript toolchain manager we use to make sure everyone working on the project is using the same versions of Node and pnpm.
- Clone the repo.
- Run `yarn` in the root of the repo to install all the package dependencies. If you have Volta installed, it will automatically fetch and use the correct versions of Node and Yarn for you.
- Run `yarn build` in the root of the repository to build all of the projects the first time. This will make sure that once you start working on one of the packages, you are working with an up to date version of the other packages in the project it depends on.
- Run `pnpm install` in the root of the repo to install all the package dependencies. If you have Volta installed, it will automatically fetch and use the correct versions of Node and Yarn for you.
- Run `pnpm build` in the root of the repository to build all of the projects the first time. This will make sure that once you start working on one of the packages, you are working with an up to date version of the other packages in the project it depends on.
- Read the project’s [ARCHITECTURE.md](./ARCHITECTURE.md) to understand the basics of how the code base works.

Once you have made changes and added tests to confirm they work correctly, you can then open a PR and we'll work with you to polish it up and get it landed!
2 changes: 1 addition & 1 deletion packages/environment-ember-loose/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"test": "glint --project __tests__/type-tests && vitest run",
"test:watch": "vitest watch",
"build": "tsc --build",
"prepack": "yarn build"
"prepack": "pnpm build"
},
"files": [
"README.md",
Expand Down
2 changes: 1 addition & 1 deletion packages/environment-ember-template-imports/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"test": "vitest run",
"test:watch": "vitest watch",
"build": "tsc --build",
"prepack": "yarn build"
"prepack": "pnpm build"
},
"files": [
"README.md",
Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"scripts": {
"test": "vitest run",
"build": "tsc --build",
"prepack": "yarn build"
"prepack": "pnpm build"
},
"dependencies": {
"golden-fleece": "^1.0.9",
Expand Down
6 changes: 3 additions & 3 deletions packages/vscode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@
"Linters"
],
"scripts": {
"pretest": "yarn build",
"pretest": "pnpm build",
"test": "node lib/__tests__/support/launch-from-cli.mjs",
"build": "yarn compile && yarn bundle",
"build": "pnpm compile && pnpm bundle",
"compile": "tsc --build",
"bundle": "esbuild lib/src/extension.js --bundle --outfile=dist/extension.js --platform=node --external:vscode --minify",
"vscode:prepublish": "yarn build",
"vscode:prepublish": "pnpm build",
"extension:package": "vsce package --no-dependencies",
"extension:publish": "vsce publish --no-dependencies"
},
Expand Down
7 changes: 3 additions & 4 deletions test-packages/ts-ember-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,14 @@ You will need the following things properly installed on your computer.

- [Git](https://git-scm.com/)
- [Node.js](https://nodejs.org/)
- [Yarn](https://yarnpkg.com/)
- [Ember CLI](https://cli.emberjs.com/release/)
- [Google Chrome](https://google.com/chrome/)

## Installation

- `git clone <repository-url>` this repository
- `cd ts-ember-app`
- `yarn install`
- `pnpm install`

## Running / Development

Expand All @@ -36,8 +35,8 @@ Make use of the many generators for code, try `ember help generate` for more det

### Linting

- `yarn lint`
- `yarn lint:fix`
- `pnpm lint`
- `pnpm lint:fix`

### Building

Expand Down
2 changes: 1 addition & 1 deletion test-packages/ts-ember-app/config/ember-cli-update.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"outputRepo": "https://github.com/ember-cli/ember-new-output",
"codemodsSource": "ember-app-codemods-manifest@1",
"isBaseBlueprint": true,
"options": ["--yarn"]
"options": ["--pnpm"]
}
]
}
Expand Down

0 comments on commit af9f714

Please sign in to comment.