Fail early if there is no "all" schema in DB

Summary: Similar to D56531547. This diff avoids storing errors in fields and just fails early instead.

Reviewed By: simonmar

Differential Revision: D56579299

fbshipit-source-id: 19702d43ccac47a5ed3c537e7dbc19c152f8bf34

glean/db/Glean/Database/Schema.hs

@@ -479,12 +479,12 @@ mkDbSchema toList cacheVar knownPids dbContent
             Nothing -> throwIO $ ErrorCall "no \"all\" schema"
             Just (_, id) -> return id
 
-    let
-        dbSchemaId =
+    dbSchemaId <-
           case IntMap.lookupMax (hashedSchemaAllVersions stored) of
-            Nothing -> error "no \"all\" schema in DB"
-            Just (_, id) -> id
+            Nothing -> throwIO $ ErrorCall "no \"all\" schema in DB"
+            Just (_, id) -> return id
 
+    let
         predicatesById = tcEnvPredicates tcEnv
         derivationDepends = HashMap.fromListWith (++)
           [ (p, pp) | (_, p, pp) <- derivationEdges predicatesById]