Log "Latest" instead of revision for fallback snapshots

Summary: This makes it easier to group by `snapshot`, the revision is also available in the `revision used` column. Reviewed By: pepeiborra Differential Revision: D56185668 fbshipit-source-id: 09961253f99dbb901a87dc3e0cd6df2e3c798097
typechecker · Apr 17, 2024 · 3c22d42 · 3c22d42
1 parent a5ff658
commit 3c22d42
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/glean/glass/Glean/Glass/Handler.hs b/glean/glass/Glean/Glass/Handler.hs
@@ -963,7 +963,7 @@ fetchSymbolsAndAttributes tracer scm repoMapping dbInfo req opts be
           Right result ->
             return
               (( result
-               , Snapshot.Latest (documentSymbolListXResult_revision result)
+               , Snapshot.Latest
                , QueryEachRepoUnrequested)
               , Nothing)
           Left _ ->

diff --git a/glean/glass/Glean/Glass/Logging.hs b/glean/glass/Glean/Glass/Logging.hs
@@ -434,5 +434,4 @@ logSnapshotStatus st = case st of
   NotFound -> Logger.setSnapshot  "Not found"
   ExactMatch -> Logger.setSnapshot  "Exact"
   Ignored -> Logger.setSnapshot  "Ignored"
-  Latest rev ->
-    Logger.setSnapshot (unRevision rev)
+  Latest -> Logger.setSnapshot "Latest"
diff --git a/glean/glass/Glean/Glass/SnapshotBackend.hs b/glean/glass/Glean/Glass/SnapshotBackend.hs
@@ -52,7 +52,7 @@ data SnapshotStatus
   | NotFound
   | ExactMatch
   | Ignored
-  | Latest Revision
+  | Latest
   deriving Show
 
 -- | Always produces the 'NilSnapshotBackend'