Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix package exports and type for legacy tooling compatibility #13

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

DRiFTy17
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added: N
  • Docs have been added / updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? N

Describe the new behavior?

To better support legacy build tooling we need to revert from "type": "module" in the package.json and remove "exports" in favor of just "main" and "module" as it was redundant anyway. When the ecosystem is ready and stable, we can reintroduce "exports".

This should not have any affect on existing consumers.

@DRiFTy17 DRiFTy17 added the patch Increment the patch version when merged label Aug 21, 2024
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner August 21, 2024 16:06
Copy link

stackblitz bot commented Aug 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 merged commit 1fcbaa7 into main Aug 21, 2024
4 checks passed
@DRiFTy17 DRiFTy17 deleted the fix/packaging branch August 21, 2024 17:34
Copy link
Contributor

🚀 PR was released in v3.0.1 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant