-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ipywidgets 8 / Notebook 7 / JupyterLab 4 #93
Conversation
This does not work yet. There is some CodeMirror tweaking logic that does not work with JupyterLab 4 (CodeMirror 6). This will require some days of work to get it right. Also we might want to consider dropping JupyterLab <=3 support, because supporting multiple CodeMirror versions may be tricky. |
7771863
to
95affc1
Compare
8bb63ba
to
27b0de8
Compare
27b0de8
to
55d1015
Compare
@martinRenou would this warrant a bump in version number? |
Compatibility should be kept for JupyterLab 3. As long as you built the wheel in an environment where JupyterLab 4 lives, the resulting wheel can be installed in an environment where JupyterLab 3 is installed. So I guess a 2.4.0 bump is enough. |
@achhina I think this is ready for merging. We can bump the version number separately. |
Builds against twosigma/beakerx_base#10 and twosigma/beakerx_kernel_groovy#17