Pin httpbin 0.7.0 and werkzeug 2.0.3 #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
httpbin 0.7.0 gets us compatibility with current versions of MarkupSafe, which dropped `soft_unicode` in version 2.1.0 [1]. werkzeug 2.0.3 [2] is the most recent version that includes the deprecated BaseResponse symbol that httpbin imports. [1]: https://markupsafe.palletsprojects.com/en/2.1.x/changes/#version-2-1-0 [2]: https://werkzeug.palletsprojects.com/en/2.2.x/changes/#version-2-0-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352.
httpbin 0.7.0 gets us compatibility with current versions of MarkupSafe, which dropped
soft_unicodein version 2.1.0.werkzeug 2.0.3 is the most recent version that includes the deprecated
BaseResponsesymbol that httpbin imports.This is just a quick fix. To properly address this we'll have to address the fact that httpbin hasn't released since 2018. This also doesn't address the very lax pinning of test dependencies in general.