Add invoke filter #4518
Open
Add invoke filter #4518
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Dec 27, 2024
Comment on lines
+921
to
+924
| * | ||
| * @param callable $callable | ||
| * @param ...$arguments | ||
| * @return mixed |
There was a problem hiding this comment.
phpdoc is not added when it does not provide information beyond the native types. But you can add usage example.
Suggested change
| * | |
| * @param callable $callable | |
| * @param ...$arguments | |
| * @return mixed | |
| * | |
| * {% set func = x => 'Hello '~x %} | |
| * {{ func|invoke('World') }} |
smnandre
reviewed
Dec 28, 2024
| */ | ||
| public static function invoke(callable $callable, ...$arguments): mixed | ||
| { | ||
| return $callable(...$arguments); |
There was a problem hiding this comment.
Don't we want to limit / check the $callable argument ?
Via checkArrow() for instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new filter
invoke, to invoke arrow functions and other php callables.See the discussion here: #4378 (comment)