Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception when timezone is false #4014

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix exception when timezone is false #4014

merged 1 commit into from
Apr 3, 2024

Conversation

Seb33300
Copy link
Contributor

@Seb33300 Seb33300 commented Apr 1, 2024 •
edited
Loading

When passing false in the timezone param, twig returns an exception:

An exception has been thrown during the rendering of a template ("Twig\Extra\Intl\IntlExtension::createDateFormatter(): Argument 5 ($timezone) must be of type ?DateTimeZone, bool given

Passing false is supported and allows to skip the timezone conversion.

Regression introduced by #3903

@Seb33300 Seb33300 mentioned this pull request Apr 2, 2024
Closed
@fabpot
Copy link
Contributor

fabpot commented Apr 3, 2024

Thank you @Seb33300.

@fabpot fabpot merged commit 64ee590 into twigphp:3.x Apr 3, 2024
10 checks passed
@Seb33300 Seb33300 deleted the patch-2 branch April 17, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seb33300 @fabpot @smnandre