Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of list() in favor of [] #3958

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Remove usage of list() in favor of [] #3958

merged 2 commits into from
Jan 5, 2024

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented Jan 5, 2024

No description provided.

@smnandre
Copy link
Contributor

smnandre commented Jan 5, 2024

There is a couple of other occurences of list() in the repo, do wo want to remove them all now ?

@fabpot
Copy link
Contributor Author

fabpot commented Jan 5, 2024

There is a couple of other occurences of list() in the repo, do wo want to remove them all now ?

Sure, I changed only the generated code. The second commit changes the code itself.

@smnandre
Copy link
Contributor

smnandre commented Jan 5, 2024

Ok! And no help needed as i see :)

@fabpot fabpot merged commit 8b4aa84 into twigphp:3.x Jan 5, 2024
68 of 69 checks passed
@fabpot fabpot deleted the list-removal branch January 5, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabpot @smnandre