-

.github/workflows/ci.yml

@@ -8,6 +8,7 @@ on:
 
 env:
     SYMFONY_PHPUNIT_DISABLE_RESULT_CACHE: 1
+    SYMFONY_DEPRECATIONS_HELPER: ignoreFile=./tests/ignore-use-yield-deprecations
 
 permissions:
   contents: read

CHANGELOG

@@ -1,5 +1,7 @@
 # 3.9.0 (2023-XX-XX)
 
+ * Add a new "yield" mode for output generation
+   The "use_yield" Environment option controls the strategy: use "false" for "echo", "true" for "yield"
  * Add return type for Symfony 7 compatibility
  * Fix premature loop exit in Security Policy lookup of allowed methods/properties
  * Deprecate all internal extension functions in favor of methods on the extension classes

tests/ErrorTest.php

@@ -304,8 +304,7 @@ public function getErroredTemplates()
             ],
         ];
     }
-/* These tests don't make sense to me
-   Depending on whether you're using echo ->render() or display(), they don't behave in the same way
+
     public function testTwigLeakOutputInDebugMode()
     {
         $output = exec(sprintf('%s %s debug', \PHP_BINARY, escapeshellarg(__DIR__.'/Fixtures/errors/leak-output.php')));
@@ -319,7 +318,6 @@ public function testDoesNotTwigLeakOutput()
 
         $this->assertSame('', $output);
     }
-*/
 }
 
 class ErrorTest_Foo

tests/Fixtures/errors/leak-output.php

@@ -27,7 +27,7 @@ public function broken()
 $loader = new ArrayLoader([
     'index.html.twig' => 'Hello {{ "world"|broken }}',
 ]);
-$twig = new Environment($loader, ['debug' => isset($argv[1])]);
+$twig = new Environment($loader, ['debug' => isset($argv[1]), 'use_yield' => false]);
 $twig->addExtension(new BrokenExtension());
 
-$twig->display('index.html.twig');
+echo $twig->render('index.html.twig');

tests/ignore-use-yield-deprecations

@@ -0,0 +1 @@
+%Since twig/twig 3.9.0: Not setting "use_yield" to "true" is deprecated.%