Track changes in runtime extensions

src/Extension/AttributeExtension.php

@@ -24,7 +24,7 @@
  *
  * @author Jérôme Tamarelle <[email protected]>
  */
-final class AttributeExtension extends AbstractExtension
+final class AttributeExtension extends AbstractExtension implements WithLastModified
 {
     private array $filters;
     private array $functions;
@@ -41,6 +41,20 @@ public function __construct(
     ) {
     }
 
+    public function getLastModified(): int
+    {
+        $lastModified = 0;
+
+        foreach ($this->objectsOrClasses as $objectOrClass) {
+            $r = new \ReflectionClass($objectOrClass);
+            if (is_file($r->getFileName()) && ($extensionTime = filemtime($r->getFileName())) > $lastModified) {
+                $lastModified = $extensionTime;
+            }
+        }
+
+        return $lastModified;
+    }
+
     public function getFilters(): array
     {
         if (!isset($this->filters)) {

src/Extension/WithLastModified.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Twig\Extension;
+
+interface WithLastModified
+{
+    public function getLastModified(): int;
+}

src/ExtensionSet.php

@@ -15,6 +15,7 @@
 use Twig\Extension\ExtensionInterface;
 use Twig\Extension\GlobalsInterface;
 use Twig\Extension\StagingExtension;
+use Twig\Extension\WithLastModified;
 use Twig\Node\Expression\Binary\AbstractBinary;
 use Twig\Node\Expression\Unary\AbstractUnary;
 use Twig\NodeVisitor\NodeVisitorInterface;
@@ -115,6 +116,9 @@ public function getLastModified(): int
             if (is_file($r->getFileName()) && ($extensionTime = filemtime($r->getFileName())) > $this->lastModified) {
                 $this->lastModified = $extensionTime;
             }
+            if ($extension instanceof WithLastModified && ($extensionTime = $extension->getLastModified()) > $this->lastModified) {
+                $this->lastModified = $extensionTime;
+            }
         }
 
         return $this->lastModified;

tests/Extension/AttributeExtensionTest.php

@@ -107,4 +107,10 @@ public function testRuntimeExtension()
         $this->assertSame([$class, 'fooFunction'], $extension->getFunctions()['foo']->getCallable());
         $this->assertSame([$class, 'fooTest'], $extension->getTests()['foo']->getCallable());
     }
+
+    public function testLastModified()
+    {
+        $extension = new AttributeExtension([ExtensionWithAttributes::class]);
+        $this->assertSame(filemtime(__DIR__ . '/Fixtures/ExtensionWithAttributes.php'), $extension->getLastModified());
+    }
 }