Fix dropdown not scrolling when there's not enough vertical space #7940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
force-pushed
the
7937-dropdown-scroll
branch
from
b471050
to
69d5d8f
Compare
4 tasks
hrb-hub
approved these changes
Nov 15, 2024
The inner dropdown container was overflowing the outer one instead of scrolling because its height was not restricted. This could be reproduced on a screen that's not tall enough e.g. small mobile screen or landscape orientation of the phone. Now we set the height to the one of the parent to always have correct height. Close #7937
charlag
force-pushed
the
7937-dropdown-scroll
branch
from
69d5d8f
to
099a16c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inner dropdown container was overflowing the outer one instead of scrolling because its height was not restricted. This could be reproduced on a screen that's not tall enough e.g. small mobile screen or landscape orientation of the phone.
Now we set the height to the one of the parent to always have correct height.
Close #7937