[sdk] Improve API & internal state #7414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
force-pushed
the
sdk-state
branch
3 times, most recently
from
c7bd01b
to
ec895e8
Compare
rezbyte
reviewed
Aug 28, 2024
tuta-sdk/rust/sdk/src/lib.rs
Outdated
| let entity_client = Arc::new(EntityClient::new( | ||
| self.rest_client.clone(), | ||
| self.json_serializer.clone(), | ||
| self.base_url.clone(), |
There was a problem hiding this comment.
Perhaps pass this by reference?
There was a problem hiding this comment.
Would be great! but we would need to define the lifetime relationship between Sdk and EntityClient and I think Uniffi types are not allowed to have lifetimes.
rezbyte
reviewed
Aug 28, 2024
charlag
force-pushed
the
dev-mail
branch
2 times, most recently
from
c763e8c
to
def698a
Compare
Co-authored-by: jat <[email protected]>
We changed the point at which the credentials are fixed in the sdk. Now they are passed in to login() method and not when creating SDK. This makes for a cleaner separation of a stateless, shared SDK and stateful, account-bound LoggedInSDK. Rest resources are now always bound to a session which allows for parallel logins and prevents accidental bugs
charlag
added
state:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the point at which the credentials are fixed in the sdk. Now they are passed in to login() method and not when creating SDK. This makes for a cleaner separation of a stateless, shared SDK and stateful, account-bound LoggedInSDK. Rest resources are now always bound to a session which allows for parallel logins and prevents accidental bugs