Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 #50

Merged
merged 29 commits into from
Nov 2, 2023
Merged

v2.0.0 #50

merged 29 commits into from
Nov 2, 2023

Conversation

BWibo
Copy link
Member

@BWibo BWibo commented Oct 15, 2023

Please also check the following points carefully:

  • Is the CHANGELOG.md complete?
  • Are all versions pinned properly for the release?
  • Are there any changes, new configuration, ... that needs to be propagated to https://github.com/tum-gis/sddi-ckan-k8s?
  • Are all new features/extensions/... documented in README.md?
  • Are there any breaking changes, that are not documented in CHANGELOG.md jet?
    • Changes, that require additional manual action by admins, when updating to this version, e.g. database updates, updats to existing user accounts, ...?
    • Explicitly test, if updating an exisitng instance to this version works. E.g. use an existing catalog or a fresh catalog with v1.3.0 and update it to this version. There should be users/entries/resources usw. in the catalog before the update.

@BWibo BWibo mentioned this pull request Oct 15, 2023
@BWibo
Copy link
Member Author

BWibo commented Oct 19, 2023

@MarijaKnezevic Please test the latest im from this PR. See #51 before, this will be helpful.

Please also check the list I added in the description of this PR above and check the boxes when it's done.

@BWibo BWibo added breaking Introduces a breaking change. type: security Something is vulnerable or not secure. labels Oct 19, 2023
@BWibo
Copy link
Member Author

BWibo commented Oct 31, 2023

@MarijaKnezevic: Check the latest release of ckanext-spatial: https://github.com/ckan/ckanext-spatial/releases/tag/v2.1.0
This should allow to use the original version and not the fork, right?

@MarijaKnezevic
Copy link
Collaborator

@BWibo Not really. In our forked spatial there are two files spatial_form.js and webassets.yml which were added/adapted to make the plugin work with our scheming.
In ckanext-spatial v2.1.0 not all the features we need are included. From the changelog file of v.2.1.0 I can see that the problem with the background map has been fixed, which is currently our problem. I posted PR 317 and added the other background map in our Docker file as suggested in this PR.
I am aware that more improvements are coming with the new version of Spatial and that we currently have an additional plugin to maintain. But I have discussed with Thomas and Andreas that we urgently need to find a solution to create a plugin that will extend our need and that we basically need to create one "master SDDI plugin" where plugin functionality is going to be extended because now we have just one more thing to maintain.

@BWibo
Copy link
Member Author

BWibo commented Nov 1, 2023

@MarijaKnezevic OK, your decision. Is this tested and ready to release then?

@MarijaKnezevic
Copy link
Collaborator

@BWibo yes, it is tested and it passed the pentest. It can be released.

@BWibo BWibo merged commit 7922f77 into devel Nov 2, 2023
1 check passed
@BWibo BWibo deleted the release/2.0.0 branch November 2, 2023 11:19
@MarijaKnezevic
Copy link
Collaborator

@BWibo I've created a backup for our Savenow instance. Could you please update it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Introduces a breaking change. type: security Something is vulnerable or not secure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants