feat(gebura): remove AppInst

tuihub · Nov 3, 2024 · 51fc077 · 51fc077
1 parent fd21429
commit 51fc077
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 48 deletions.
diff --git a/proto/librarian/sephirah/v1/gebura.proto b/proto/librarian/sephirah/v1/gebura.proto
@@ -185,45 +185,21 @@ message DownloadAppBinaryResponse {
   string token = 2;
 }
 
-message CreateAppInstRequest {
-  AppInst app_inst = 1;
-}
-
-message CreateAppInstResponse {
-  librarian.v1.InternalID id = 1;
-}
-
-message UpdateAppInstRequest {
-  AppInst app_inst = 1;
+message AddAppRunTimeRequest {
+  librarian.v1.InternalID app_id = 1;
+  librarian.v1.InternalID device_id = 2;
+  librarian.v1.TimeRange time_range = 3;
 }
 
-message UpdateAppInstResponse {}
+message AddAppRunTimeResponse {}
 
-message ListAppInstsRequest {
-  librarian.v1.PagingRequest paging = 1;
+message SumAppRunTimeRequest {
+  repeated librarian.v1.InternalID app_id_filter = 1;
   repeated librarian.v1.InternalID device_id_filter = 2;
-  repeated librarian.v1.InternalID id_filter = 3;
-  repeated librarian.v1.InternalID app_id_filter = 4;
+  librarian.v1.TimeAggregation time_aggregation = 3;
 }
 
-message ListAppInstsResponse {
-  librarian.v1.PagingResponse paging = 1;
-  repeated AppInst app_insts = 2;
-}
-
-message AddAppInstRunTimeRequest {
-  librarian.v1.InternalID app_inst_id = 1;
-  librarian.v1.TimeRange time_range = 2;
-}
-
-message AddAppInstRunTimeResponse {}
-
-message SumAppInstRunTimeRequest {
-  librarian.v1.InternalID app_inst_id = 1;
-  librarian.v1.TimeAggregation time_aggregation = 2;
-}
-
-message SumAppInstRunTimeResponse {
+message SumAppRunTimeResponse {
   message Group {
     librarian.v1.TimeRange time_range = 1;
     google.protobuf.Duration duration = 2;
@@ -470,12 +446,6 @@ message AppCategory {
   repeated librarian.v1.InternalID app_info_ids = 4;
 }
 
-message AppInst {
-  librarian.v1.InternalID id = 1;
-  librarian.v1.InternalID device_id = 2;
-  librarian.v1.InternalID app_id = 3;
-}
-
 message SharedAppSave {
   librarian.v1.InternalID id = 1;
   string name = 2;

diff --git a/proto/librarian/sephirah/v1/sephirah.proto b/proto/librarian/sephirah/v1/sephirah.proto
@@ -185,16 +185,9 @@ service LibrarianSephirahService {
   rpc DownloadAppBinary(DownloadAppBinaryRequest) returns (DownloadAppBinaryResponse);
 
   // `Gebura` `Normal`
-  rpc CreateAppInst(CreateAppInstRequest) returns (CreateAppInstResponse);
-  // `Gebura` `Normal`
-  rpc UpdateAppInst(UpdateAppInstRequest) returns (UpdateAppInstResponse);
-  // `Gebura` `Normal`
-  rpc ListAppInsts(ListAppInstsRequest) returns (ListAppInstsResponse);
-
-  // `Gebura` `Normal`
-  rpc AddAppInstRunTime(AddAppInstRunTimeRequest) returns (AddAppInstRunTimeResponse);
+  rpc AddAppRunTime(AddAppRunTimeRequest) returns (AddAppRunTimeResponse);
   // `Gebura` `Normal` Only support AGGREGATION_TYPE_OVERALL
-  rpc SumAppInstRunTime(SumAppInstRunTimeRequest) returns (SumAppInstRunTimeResponse);
+  rpc SumAppRunTime(SumAppRunTimeRequest) returns (SumAppRunTimeResponse);
 
   // `Gebura` `Normal`
   rpc UploadAppSaveFile(UploadAppSaveFileRequest) returns (UploadAppSaveFileResponse);