-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci build script #25
base: main
Are you sure you want to change the base?
Conversation
This makes sure all dependencies are configured as if on first checkout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are improving this script maybe we could try to make the commands a bit more quiet? The messages from the script are very hard to find in the mass of output. Alternatively we could just print our own messages in red to be able to see them more easily.
I agree that the script is very verbose, especially the python module build. I will make it quiet by default and add a |
The script is now more quiet by default. The previous behavior can be restored by passing the Status, info and warning messages from the script are now bold and may be colored (in the case of info and warning) improving the readability. Additional status messages were also added to inform the user what is currently being done, |
This PR updates the build script so the legacy environment variables are still considered while configuring.
It also explicitly specifies the llvm version cinnamon currently depends on in the build script. This removes the loose coupling of this repo to https://github.com/oowekyala/llvm-project/tree/cinnamon-llvm as it could result in broken builds of older cinnamon checkouts down the line. Any necessary patches to llvm are stored in
patches/llvm
and are automatically applied on checkout by the CI build script.As a result of this, Cinnamon is now based on the latest llvm 19.1.3 release (with some patches applied).
The
just configure
command now also utilizes the CI build script. This results in a "single source of truth" for the project configuration.Note: The CI build and test now also runs for pull requests. This should reduce the chance of a broken build on the main branch after a merge.
References #14