Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci build script #25

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Update ci build script #25

wants to merge 10 commits into from

Conversation

Felix-Rm
Copy link
Collaborator

This PR updates the build script so the legacy environment variables are still considered while configuring.

It also explicitly specifies the llvm version cinnamon currently depends on in the build script. This removes the loose coupling of this repo to https://github.com/oowekyala/llvm-project/tree/cinnamon-llvm as it could result in broken builds of older cinnamon checkouts down the line. Any necessary patches to llvm are stored in patches/llvm and are automatically applied on checkout by the CI build script.

As a result of this, Cinnamon is now based on the latest llvm 19.1.3 release (with some patches applied).

The just configure command now also utilizes the CI build script. This results in a "single source of truth" for the project configuration.

Note: The CI build and test now also runs for pull requests. This should reduce the chance of a broken build on the main branch after a merge.

References #14

@Felix-Rm Felix-Rm added the enhancement New feature or request label Oct 30, 2024
@Felix-Rm Felix-Rm self-assigned this Oct 30, 2024
Copy link
Collaborator

@oowekyala oowekyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are improving this script maybe we could try to make the commands a bit more quiet? The messages from the script are very hard to find in the mass of output. Alternatively we could just print our own messages in red to be able to see them more easily.

.github/workflows/build-ci.sh Outdated Show resolved Hide resolved
.github/workflows/build-ci.sh Outdated Show resolved Hide resolved
@Felix-Rm
Copy link
Collaborator Author

Felix-Rm commented Nov 6, 2024

While we are improving this script maybe we could try to make the commands a bit more quiet? The messages from the script are very hard to find in the mass of output. Alternatively we could just print our own messages in red to be able to see them more easily.

I agree that the script is very verbose, especially the python module build. I will make it quiet by default and add a verbose option for debugging. The output of the cmake configure as well as the build should remain untouched in my opinion. I will also add highlighting for warnings and other information.

@Felix-Rm
Copy link
Collaborator Author

While we are improving this script maybe we could try to make the commands a bit more quiet? The messages from the script are very hard to find in the mass of output. Alternatively we could just print our own messages in red to be able to see them more easily.

The script is now more quiet by default. The previous behavior can be restored by passing the -verbose flag. The cmake configure output is not currently silenced as it may contain some important info and therefore isn't purely spamming the console. Although the policy warnings and other developer warnings are now hidden. @oowekyala let me know if cmake should also be fully quiet by default.

Status, info and warning messages from the script are now bold and may be colored (in the case of info and warning) improving the readability. Additional status messages were also added to inform the user what is currently being done,
as some progress output is now silenced in non verbose mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants