Don't restart scanner renewer on every Next call #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbee
force-pushed
the
renew
branch
2 times, most recently
from
7b7d801 to
e21effc
Compare
aaronbee
force-pushed
the
renew
branch
2 times, most recently
from
2131baa to
15a3846
Compare
Most calls to Next are just reading some buffered results. The scanner renewer only needs to be stopped and started again when we ask for more results from HBase. Also, we shouldn't start a renewer if we know we have already fetched the final results. Pass in client's logger to scanner. Use renewLoop's ctx in renew(). Doubled scannerLease sleeps in integration tests to reduce flakiness of tests.
This can be used to identify scanner leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most calls to Next are just reading some buffered results. The scanner renewer only needs to be stopped and started again when we ask for more results from HBase. Also, we shouldn't start a renewer if we know we have already fetched the final results.