List of improvements expected for tslearn version 0.6.2 #460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the version 0.6.2 of tslearn, the following improvements are expected:
Segmentation fault
):test_symmetric_cdist
--> The failing rate of this test is about 3/4test_gamma_soft_dtw
--> The failing rate of this test is about 1/5When these tests are failing, the error messages can be different from one fail to the other: the Segmentation fault can occur in different lines of the code. These two tests are currently skipped with MacOS for Python 3.9.
be
?We should test both cases: with backend inferred from data and with backend explicitly specified, even with data from another format.
--> This problem has been dealt with in PR Cast the input data to backend option and test functions in metrics for different input data types and different backend options. #479.
For example what does it mean for DTW to support the
PyTorch
backend, do we differentiate at fixed path?--> This problem has been dealt with in PR Improve backend docstrings #482.
SoftDTWLossPyTorch
should be improved.--> The documentation of the class
SoftDTWLossPyTorch
has been improved in the PR Improve the docstring of the class SoftDTWLossPyTorch #467.Backend
inbackend/backend.py
, should we overload__getattr__
instead of listing all attributes?--> This requirement has been dealt with in PR Simplify backend #471.