Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ember] set "target" to ESNext #249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Feb 1, 2024

I noticed in a project: I didn't have access to Array.prototype.toSpliced, which landed in TS 5.2, so this should help others with that problem.

@orta
Copy link
Member

orta commented Feb 4, 2024

I'd be careful with this one, 'esnext' implies always being bleeding edge and that's not really the right thing to be recommending when making a base like this

@NullVoxPopuli
Copy link
Contributor Author

What's an example of that backfiring?

@orta
Copy link
Member

orta commented Feb 4, 2024

The browser/js runtime does not have function that the types claim to have and you get unexpected crashes - I assume for ember target is based on what they declare as their minimum support window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants