Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pre-commmit): add additional basic formatters #51

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

tsandrini
Copy link
Owner

@tsandrini tsandrini commented Aug 8, 2024

Overview

Adds additional basic file checks to pre-commit-hooks

Testing

Dependencies

Screenshots

Checklist

  • I have tested the relevant changes locally.
  • I have checked that nix flake check passes.
  • I have ensured my commits follow the project's commits guidelines.
  • I have checked that the changes follow a linear history.
  • (If applicable) I have commented any relevant parts of my code.
  • (If applicable) I have added appropriate unit/feature tests.
  • (If applicable) I have updated the documentation accordingly (in English).

Additional Notes

Summary by Sourcery

Add new basic file checks to pre-commit hooks and disable yamlfmt in treefmt configuration.

New Features:

  • Add additional basic file checks to pre-commit hooks, including trimming trailing whitespace, checking mixed line endings, fixing end-of-file issues, ensuring executables have shebangs, and checking for added large files.

Enhancements:

  • Disable yamlfmt in treefmt configuration.

@tsandrini tsandrini self-assigned this Aug 8, 2024
Copy link

sourcery-ai bot commented Aug 8, 2024

Reviewer's Guide by Sourcery

This pull request adds additional basic file formatters to the pre-commit hooks configuration. The changes include enabling several new formatters and checks, as well as commenting out an existing YAML formatter.

File-Level Changes

Files Changes
flake-parts/pre-commit-hooks.nix
flake-parts/treefmt.nix
Added new formatters and checks to pre-commit hooks, and adjusted existing formatter configurations.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tsandrini - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you provide more details in the PR description about the specific changes made and the reasoning behind them, especially regarding the removal of the YAML formatter?
  • The additions of basic pre-commit hooks are good for maintaining code quality. Nice work on including checks for trailing whitespace, mixed line endings, and file endings.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@tsandrini tsandrini merged commit 6feca5a into main Aug 8, 2024
2 checks passed
@tsandrini tsandrini deleted the parts-update branch August 8, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant