Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update tokio #1138

Merged
merged 1 commit into from
Jan 14, 2025
Merged

chore: update tokio #1138

merged 1 commit into from
Jan 14, 2025

Conversation

helio-frota
Copy link
Collaborator

  • Past week I did a basic investigation with new tokio version and importers
    • We are using a tokio version from ~1 year ago
    • I need to run the importers with hotspot to see if we have differences with the tokio versions
      • result: nothing major changed

@helio-frota helio-frota requested a review from dejanb January 14, 2025 10:26
@helio-frota
chore: update tokio
4b35ced 
* Past week I did a basic investigation with new tokio version and importers
  * We are using a tokio version from ~1 year ago
  * I need to run the importers with hotspot to see if we have differences with the tokio versions
    * result: nothing major changed
@ctron
Copy link
Contributor

ctron commented Jan 14, 2025

I think it's ok to upgrade. But it's not that bad. We require tokio 1.30, but in fact we are using 1.42, as the .lock file shows.

Cargo.toml lists what is required, Cargo.lock what is being used. As we do check in the lock file, we need to refresh it. But that is done during the release process.

@ctron ctron enabled auto-merge January 14, 2025 10:39
@helio-frota
Copy link
Collaborator Author

you right https://github.com/trustification/trustify/blob/main/Cargo.lock#L7987 1.42
I didn't checked that 👍
thanks for the extras

@ctron ctron added this pull request to the merge queue Jan 14, 2025
Merged via the queue into trustification:main with commit dc319f5 Jan 14, 2025
2 checks passed
@helio-frota helio-frota deleted the tokio-update branch January 14, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctron ctron ctron approved these changes

@dejanb dejanb Awaiting requested review from dejanb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helio-frota @ctron