feat: create GeneratedFrom relationship from CycloneDX dependencies #1135
+1,793
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes trustification#1131 I'm not entirely sure my right and left is correct, because I don't fully grok the expected output of `analysis/root-component` and `analysis/dep`. Signed-off-by: Jim Crossley <[email protected]>
|
|
||
| // https://github.com/trustification/trustify/issues/1131 | ||
| // Do we need to qualify this so that only "arch=src" refs | ||
| // get the GeneratedFrom relationship? |
There was a problem hiding this comment.
good question - originally I thought we should think of 'red hat' mode as only applying to ingestion eg. I do not think we have to bake anything into rest api or add any additional metadata ... we can figure out that a binary package with GENERATED_FROM relationship to a src package means just that.
JimFuller-RedHat
approved these changes
Jan 14, 2025
ctron
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1131
I'm not entirely sure my right and left is correct, because I don't fully grok the expected output of
analysis/root-componentandanalysis/dep.