feat: add ingestion time to source documents #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrossley3
requested changes
Dec 6, 2024
Should be easy enough to add a test for it, no? |
ctron
force-pushed
the
feature/add_time_1
branch
from
debfb83 to
72138fd
Compare
|
Renamed the field. |
ctron
force-pushed
the
feature/add_time_1
branch
from
72138fd to
4054521
Compare
Co-authored-by: Jim Crossley <[email protected]>
ctron
force-pushed
the
feature/add_time_1
branch
from
4054521 to
6ed7bfa
Compare
|
Added a test case. |
But not one that affirms what you weren't sure about. C'mon, you can do it! |
I am sorry, I don't understand. |
Relates trustification#1077 Signed-off-by: Jim Crossley <[email protected]>
I pushed a fix |
jcrossley3
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an ingestion timestamp.
@jcrossley3 not sure this makes it available for search too.
Also see: #1077