validate callable retry logic in Host

truongbo17 · Dec 24, 2022 · a0b8dec · a0b8dec
1 parent 19bddd0
commit a0b8dec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Exception/InvalidCallableException.php b/src/Exception/InvalidCallableException.php
@@ -6,7 +6,7 @@
 
 final class InvalidCallableException extends Exception
 {
-    public function __construct(string $message = 'Callable must return a boolean value', int $code = 0, ?\Throwable $previous = null)
+    public function __construct(string $message = 'Invalid callable retry logic', int $code = 0, ?\Throwable $previous = null)
     {
         parent::__construct($message, $code, $previous);
     }

diff --git a/src/Servers/Host.php b/src/Servers/Host.php
@@ -3,6 +3,7 @@
 namespace TruongBo\ProxyRotation\Servers;
 
 use TruongBo\ProxyRotation\Exception\HostException;
+use TruongBo\ProxyRotation\Exception\InvalidCallableException;
 
 final class Host implements HostInterface
 {
@@ -62,9 +63,14 @@ public function validateConstructor()
     /**
      * Add retry logic
      * @param callable $retry_logic
+     * @throws InvalidCallableException
      */
     public function addRetryLogic(callable $retry_logic): void
     {
+        if(!is_callable($retry_logic)){
+            throw new InvalidCallableException();
+        }
+
         $this->retries_logic[] = $retry_logic;
     }